[webkit-reviews] review granted: [Bug 13304] REGRESSION(14784): WebKit doesn't dynamically reflect changes to the highlight color in System Preferences : [Attachment 14356] proposed fix

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Alexey Proskuryakov <ap at webkit.org>'s
request for review:
Bug 13304: REGRESSION(14784): WebKit doesn't dynamically reflect changes to the
highlight color in System Preferences
http://bugs.webkit.org/show_bug.cgi?id=13304

Attachment 14356: proposed fix
http://bugs.webkit.org/attachment.cgi?id=14356&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
+    /* Have to just leak the cells, since statics are destroyed with no
autorelease pool available */

I know you just moved this comment, but it is not true. You can create an
autorelease pool of your own and then call HardRelease before draining the
autorelease pool. In fact, even removeObserver: needs an autorelease pool.

On the other hand, I think we should just change it so that RenderThemeMac is
never destroyed.

    RenderTheme* theme()
    {
	static RenderThemeMac* macTheme = new RenderThemeMac;
	return macTheme;
    }

r=me, because this issue is a minor one as long as you aren't seeing a crash on
quit