[webkit-reviews] review requested: [Bug 13499] [qmake] Make it
possible to use qmake for other ports : [Attachment 14312]
Make it possible to compile the Gdk port using qmake
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed May 2 16:04:05 PDT 2007
Holger Freyther <freyther at handhelds.org> has asked for review:
Bug 13499: [qmake] Make it possible to use qmake for other ports
http://bugs.webkit.org/show_bug.cgi?id=13499
Attachment 14312: Make it possible to compile the Gdk port using qmake
http://bugs.webkit.org/attachment.cgi?id=14312&action=edit
------- Additional Comments from Holger Freyther <freyther at handhelds.org>
Update as requested.
The webkitdirs.pm/build-webkit script should follow the CodingStyle. I have
decided to leave the prefix in as this is something both Qt and Gdk port will
need to take a look. I have added --gdk support to the script, I was not able
to use GetOption as I had to share the option between webkitdirs.pm and
build-webkit
Simplify the INCLUDEPATH and other shared resources by sharing them in
WebKit.pri
PS: For the Qt port I had to change a method signature from float,float to
WebCore::FloatSize in DragImageQt.cpp and for the Gdk I had to add an empty
stub for ImageBuffer::context. These two changes will not be found in the above
patch.
More information about the webkit-reviews
mailing list