[webkit-reviews] review denied: [Bug 13499] [qmake] Make it possible to use qmake for other ports : [Attachment 14293] Make it possible to compile the Gdk port using qmake

[bugzilla-daemon at webkit.org]

Mark Rowe (bdash) <bdash at webkit.org> has denied Holger Freyther
<freyther at handhelds.org>'s request for review:
Bug 13499: [qmake] Make it possible to use qmake for other ports
http://bugs.webkit.org/show_bug.cgi?id=13499

Attachment 14293: Make it possible to compile the Gdk port using qmake
http://bugs.webkit.org/attachment.cgi?id=14293&action=edit

------- Additional Comments from Mark Rowe (bdash) <bdash at webkit.org>
+    if ((isGdk()) and ($path =~ /WebCore/)) {

I dont think you need so many parenthesis here.

+sub isGdk()
+{
+    return defined($ENV{'BUILD_GDK'})
+}

It would be great if this could be controlled by a build-webkit command-line
argument.  It's more natural to do 'build-webkit --gdk' than 'BUILD_GDK=1
build-webkit' IMO.

+sub buildQMakeGdkProject($$)

Inside this function there are a few instances of "if(..)" -- our style
guidelines call for a space before the parenthesis.

+gdk-port:CONFIG  += link_pkgconfig

The += is indented weirdly here.

+gdk-port:DEFINES += BUILDING_GDK__=1 BUILDING_CAIRO__
+gdk-port:CONFIG  += link_pkgconfig

Lining up the +='s with whitespace goes against our normal code style
guidelines, so it may not be a good idea in build scripts either.

The duplication of the INCLUDEPATH and gdk-port:* settings in WebCore.pro and
WebKit.pri isn't ideal. It'd be great if there were some way around it.