[webkit-reviews] review requested: [Bug 12778] REGRESSION: Nightly won't load Curl plugin for full page use : [Attachment 13911] proposed fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Mar 31 10:22:02 PDT 2007


Alexey Proskuryakov <ap at webkit.org> has asked  for review:
Bug 12778: REGRESSION: Nightly won't load Curl plugin for full page use
http://bugs.webkit.org/show_bug.cgi?id=12778

Attachment 13911: proposed fix
http://bugs.webkit.org/attachment.cgi?id=13911&action=edit

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
My diagnosis was wrong - it's fine for +[WebView
_viewClass:andRepresentationClass:forMIMEType:] to return
WebHTMLView/WebHTMLRepresentation, as plugins are also handled by these.

The actual problem seems to be in DOMImplementation::createDocument(), which
hates plugins (it also mishandles Adobe SVG and any xml MIME types now).

I don't know how to make a test for this fix.



More information about the webkit-reviews mailing list