[webkit-reviews] review denied: [Bug 12959] REGRESSION: Edit -> Copy not enabled on standalone images : [Attachment 13884] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 30 04:40:16 PDT 2007

mitz at webkit.org has denied Andrew Wellington <proton at wiretapped.net>'s request
for review:
Bug 12959: REGRESSION: Edit -> Copy not enabled on standalone images

Attachment 13884: Proposed patch

------- Additional Comments from mitz at webkit.org
Standalone image documents are mutable (via JS) after they're opened. This
means that this can deref a 0 pointer or set image to 0:

+	 Node *image = doc->body()->firstChild();

It also means that renderer() here may be 0 or not a RenderImage:

+    RenderImage* renderer = static_cast<RenderImage*>(imageNode->renderer());

Please don't add another image:
+	 * editing/pasteboard/resources/icon-gold.png: Added.

You can use editing/resources/abe.jpg.

\ No newline at end of file

Please add it.

Stars should be next to C++ types:
+	 Document *doc = m_frame->document();
+	 Node *image = doc->body()->firstChild();

+    void writeImage(Node *imageNode, const KURL& url);

+void Pasteboard::writeImage(Node *imageNode, const KURL& url)

But next to Obj-C object variables' names:
+    NSArray* types = writableTypesForImage();

r- because in its current form, the patch makes it possible for a website to
crash the browser.

More information about the webkit-reviews mailing list