[webkit-reviews] review denied: [Bug 13220] [S60] Browser doesn't support for embedded DRM image content. : [Attachment 13851] Add DRM image decoder support for OSS Browser.

[bugzilla-daemon at webkit.org]

Yongjun Zhang <yongjun.zhang at nokia.com> has denied Hong Zhao
<hong.a.zhao at nokia.com>'s request for review:
Bug 13220: [S60] Browser doesn't support for embedded DRM image content.
http://bugs.webkit.org/show_bug.cgi?id=13220

Attachment 13851: Add DRM image decoder support for OSS Browser.
http://bugs.webkit.org/attachment.cgi?id=13851&action=edit

------- Additional Comments from Yongjun Zhang <yongjun.zhang at nokia.com>
The fix is incorrect:
1. function name "DisplayDRMImageL" needs to be something like
"DecodeDRMImageL" because you just decode DRM image in this function.
2. the condition to trigger DRM encoding is wrong - any error image (no matter
is drm or now) will trigger DRM decoding.
3. Performance is very bad because DisplayDRMImageL is called very time when a
decoding error occurs.
4. Don't use sychrous decoding, WaitForRequest will block the active object and
the whole image deocoder halts.
5. The whole idea of StaticImagedecoder is to reuse the Bufferdecoder, should
not create another  buffered decoder for drm images.