[webkit-reviews] review requested: [Bug 13203] REGRESSION: Repro crash in -[WebBaseNetscapePluginView(WebNPPCallbacks) destroyStream:reason:] navigating away from page with DivX movie plug-in : [Attachment 13855] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 28 17:26:07 PDT 2007


Geoffrey Garen <ggaren at apple.com> has asked  for review:
Bug 13203: REGRESSION: Repro crash in
-[WebBaseNetscapePluginView(WebNPPCallbacks) destroyStream:reason:] navigating
away from page with DivX movie plug-in
http://bugs.webkit.org/show_bug.cgi?id=13203

Attachment 13855: patch
http://bugs.webkit.org/attachment.cgi?id=13855&action=edit

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
This patch eschews an "Is this stream valid?" check in favor of a "Does this
stream belong to the plug-in using it?" check. So it avoids introducing a
function that can create subtle bugs by promising to do more than it actually
can, even though It doesn't do much more in the way of guarding against bad
behavior.



More information about the webkit-reviews mailing list