[webkit-reviews] review granted: [Bug 13021] XPath can be very slow
: [Attachment 13724] partial fix 2 v3
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Mar 24 20:18:46 PDT 2007
Darin Adler <darin at apple.com> has granted Alexey Proskuryakov <ap at webkit.org>'s
request for review:
Bug 13021: XPath can be very slow
http://bugs.webkit.org/show_bug.cgi?id=13021
Attachment 13724: partial fix 2 v3
http://bugs.webkit.org/attachment.cgi?id=13724&action=edit
------- Additional Comments from Darin Adler <darin at apple.com>
+ // This does everything appendChild() would do in this situation, but
much more efficiently.
Misleading comment because this does what appendChild would do *if*
m_ignoreChildrenChanged was set.
+ RefPtr<Node> n = attrs->item(i);
+ if (nodeMatches(n.get()))
+ nodes.append(n);
Would be more efficient to append n.release().
+ bool nodeMatches(Node* node) const;
Don't need the name "node" here.
r=me
More information about the webkit-reviews
mailing list