[webkit-reviews] review requested: [Bug 13138] StringImpl::isLower calls |islower| for non-ASCII characters : [Attachment 13807] patch 3 : addressing Darin's concerns

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Mar 24 20:16:20 PDT 2007


Jungshik Shin <jungshik.shin at gmail.com> has asked  for review:
Bug 13138: StringImpl::isLower calls |islower| for non-ASCII characters
http://bugs.webkit.org/show_bug.cgi?id=13138

Attachment 13807: patch 3 : addressing Darin's concerns
http://bugs.webkit.org/attachment.cgi?id=13807&action=edit

------- Additional Comments from Jungshik Shin <jungshik.shin at gmail.com>
Ok. I made changes you suggested. I also applied the same technique to
EqualIgnoringCase. 

As for non-BMP charcters with case distinctions, there are two groups excluding
'language tagging characters' (at U+10xxxx) nobody is likely to use. One is
Deseret alphabet and the other is Mathematical symbols. 


http://www.unicode.org/charts/PDF/U10400.pdf
http://www.unicode.org/charts/PDF/U1D400.pdf



More information about the webkit-reviews mailing list