[webkit-reviews] review requested: [Bug 13138] StringImpl::isLower calls |islower| for non-ASCII characters : [Attachment 13799] path

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Mar 24 13:37:01 PDT 2007

Jungshik Shin <jungshik.shin at gmail.com> has asked Alexey Proskuryakov
<ap at webkit.org> for review:
Bug 13138: StringImpl::isLower calls |islower| for non-ASCII characters

Attachment 13799: path

------- Additional Comments from Jungshik Shin <jungshik.shin at gmail.com>
this patch 'fixes' both isLower and lower. 

This is still broken for non-BMP characters, though. We may just consider
calling the corresponding ICU functions because ICU folks must have done a good
job at both optimization and 'correctness'.

More information about the webkit-reviews mailing list