[webkit-reviews] review requested: [Bug 12963] Inconsistencies in JS array extras with Mozilla implementation : [Attachment 13786] Complete patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 23 15:01:34 PDT 2007


Jeff Walden (remove +bwo to email) <jwalden+bwo at mit.edu> has asked  for review:
Bug 12963: Inconsistencies in JS array extras with Mozilla implementation
http://bugs.webkit.org/show_bug.cgi?id=12963

Attachment 13786: Complete patch
http://bugs.webkit.org/attachment.cgi?id=13786&action=edit

------- Additional Comments from Jeff Walden (remove +bwo to email)
<jwalden+bwo at mit.edu>
Returning false for an array index whose element is undefined seems to be a
bug, because hasProperty just returns the result of getPropertySlot.

This patch includes tests, passes all of them, and regresses no existing tests.



More information about the webkit-reviews mailing list