[webkit-reviews] review denied: [Bug 13127] pass Frame context to ChromeClient::createWindow and friends : [Attachment 13715] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 21 15:13:34 PDT 2007


Maciej Stachowiak <mjs at apple.com> has denied MorganL
<morganl.webkit at yahoo.com>'s request for review:
Bug 13127: pass Frame context to ChromeClient::createWindow and friends
http://bugs.webkit.org/show_bug.cgi?id=13127

Attachment 13715: patch
http://bugs.webkit.org/attachment.cgi?id=13715&action=edit

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
- This breaks the Qt build, would be better not to do that.

- Since the Frame argument is currently unused, it would be good to add a
comment noting not to remove it, since people otherwise remove apparently dead
code.

r- for these two issues, otherwise works fine.



More information about the webkit-reviews mailing list