[webkit-reviews] review denied: [Bug 12938] Google calendar settings page crashes : [Attachment 13725] Revised patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 20 14:10:59 PDT 2007

Darin Adler <darin at apple.com> has denied Marvin Decker
<marv.decker at gmail.com>'s request for review:
Bug 12938: Google calendar settings page crashes

Attachment 13725: Revised patch

------- Additional Comments from Darin Adler <darin at apple.com>
Thanks. Looks like a good fix!

A style comment that I think I already made last time:

+void Document::removeForm(HTMLFormElement* form) {

Brace goes on next line.

We need a regression test that demonstrates the bug.

Should remove the conflict markers in the change log.

review- because of the lack of a regression test.

More information about the webkit-reviews mailing list