[webkit-reviews] review granted: [Bug 13123] CSS selectors that use :lang, :not, and namespaces do not serialize correctly : [Attachment 13709] patch, with change log and test case

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 20 06:48:46 PDT 2007


mitz at webkit.org has granted Darin Adler <darin at apple.com>'s request for review:
Bug 13123: CSS selectors that use :lang, :not, and namespaces do not serialize
correctly
http://bugs.webkit.org/show_bug.cgi?id=13123

Attachment 13709: patch, with change log and test case
http://bugs.webkit.org/attachment.cgi?id=13709&action=edit

------- Additional Comments from mitz at webkit.org
The outer if block needs braces.

+    if (m_match == CSSSelector::None || !prefix.isNull() || localName !=
starAtom)
+	 if (prefix.isNull())
+	     str = localName;
+	 else
+	     str = prefix + "|" + localName;

r=me



More information about the webkit-reviews mailing list