[webkit-reviews] review granted: [Bug 13029] Permit NPAPI plug-ins to see HTTP response headers : [Attachment 13710] Proposed solution, take 4

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 19 20:46:33 PDT 2007

Darin Adler <darin at apple.com> has granted Deneb Meketa <dmeketa at adobe.com>'s
request for review:
Bug 13029: Permit NPAPI plug-ins to see HTTP response headers

Attachment 13710: Proposed solution, take 4

------- Additional Comments from Darin Adler <darin at apple.com>
+	 char statusStr[10];
+	 sprintf(statusStr, "%d", [httpResponse statusCode]);

To avoid getting the security "cops" on our backs, lets use snprintf here
instead of plain old sprintf.

+    if (obj && (browser->version >= NPVERS_HAS_RESPONSE_HEADERS)) {
+	 notifyStream(obj, stream->url, stream->headers);
+    }

No braces around a single-line if statement.

I'm going to say r=me, but I'd like to see a version with snprintf.

More information about the webkit-reviews mailing list