[webkit-reviews] review denied: [Bug 13096] make it possible to enable USE(MULTIPLE_THREADS) on other platforms : [Attachment 13674] patch: make isMainThread be a static member function

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 19 20:38:51 PDT 2007


Darin Adler <darin at apple.com> has denied MorganL <morganl.webkit at yahoo.com>'s
request for review:
Bug 13096: make it possible to enable USE(MULTIPLE_THREADS) on other platforms
http://bugs.webkit.org/show_bug.cgi?id=13096

Attachment 13674: patch: make isMainThread be a static member function
http://bugs.webkit.org/attachment.cgi?id=13674&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
This function is quite performance-critical. Thus I'd prefer that the Darwin
versino of the function be marked inline.

+  return pthread_main_np() == 1;

That's incorrect. != 0 would be correct.

review- before of the incorrect call for pthread_main_np()



More information about the webkit-reviews mailing list