[webkit-reviews] review requested: [Bug 13029] Permit NPAPI plug-ins to see HTTP response headers : [Attachment 13710] Proposed solution, take 4

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 19 17:13:51 PDT 2007


Deneb Meketa <dmeketa at adobe.com> has asked  for review:
Bug 13029: Permit NPAPI plug-ins to see HTTP response headers
http://bugs.webkit.org/show_bug.cgi?id=13029

Attachment 13710: Proposed solution, take 4
http://bugs.webkit.org/attachment.cgi?id=13710&action=edit

------- Additional Comments from Deneb Meketa <dmeketa at adobe.com>
New patch addressing bdash's comments - thanks for the guidance.

Updated everything to what I think is correct brace style.

Made suggested change from cStringUsingEncoding: to dataUsingEncoding:.  The
double null termination was defensive coding, but I removed the redundant call
and added a comment that the bottleneck lower down would do the job.



More information about the webkit-reviews mailing list