[webkit-reviews] review requested: [Bug 12595] REGRESSION: Can't add item to cart at lnt.com (JS type error) : [Attachment 13675] new patch

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Fri Mar 16 16:10:47 PDT 2007

Antti Koivisto <koivisto at iki.fi> has asked  for review:
Bug 12595: REGRESSION: Can't add item to cart at lnt.com (JS type error)

Attachment 13675: new patch

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
I ended up rewriting the patch since I observed the behavior of Darin's patch
did not quite match Firefox. Firefox seems to remember all names that have been
used to access an element. Names that have not been used are forgotten. I
expanded the test case to cover this and some other behaviors.

I did not include the large and somewhat risky looking refactoring from Darin's
patch to get rid of DOMNamedNodesCollection. The issues it fixes (at least that
you can't use item() on DOMNamedNodesCollections) are not directly related to
this bug, are not regressions and should be handled separately.

No memory thrashing observed with this patch on those pages.

More information about the webkit-reviews mailing list