[webkit-reviews] review denied: [Bug 13084] ASSERTION FAILED: !m_clients.contains(c) in WebCore::CachedResource::ref(WebCore::CachedResourceClient*) : [Attachment 13667] Add a method to get all images used by a renderer

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Fri Mar 16 14:38:33 PDT 2007

Dave Hyatt <hyatt at apple.com> has denied Dave Hyatt <hyatt at apple.com>'s request
for review:
Bug 13084: ASSERTION FAILED: !m_clients.contains(c) in

Attachment 13667: Add a method to get all images used by a renderer

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
I disagree with the idea of minimizing refs and derefs, since refs even on the
same image need to count as accesses of the image.

However it is true that the same resource should not be getting multiple
notifications for the same image load.

I think a better way to solve this problem is to convert the cached resource
client set to be a counted set.  That way multiple refs and derefs can still
occur and we can still have meaningful asserts.

More information about the webkit-reviews mailing list