[webkit-reviews] review denied: [Bug 11588] tables misrender because WebKit lacks support for <table> cols attribute : [Attachment 13508] patch for implementing 'cols' attribute in <table> tag

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Wed Mar 14 00:32:31 PDT 2007


Mark Rowe (bdash) <bdash at webkit.org> has denied Mark Rowe (bdash)
<bdash at webkit.org>'s request for review:
Bug 11588: tables misrender because WebKit lacks support for <table> cols
attribute
http://bugs.webkit.org/show_bug.cgi?id=11588

Attachment 13508: patch for implementing 'cols' attribute in <table> tag
http://bugs.webkit.org/attachment.cgi?id=13508&action=edit

------- Additional Comments from Mark Rowe (bdash) <bdash at webkit.org>
This patch hasn't addressed many of the previous comments.  It still lacks
layout tests, has many tabs throughout it, and includes the now-incorrect "//
###" todo marker used by the KDE folk.	There are many places in which the code
doesn't meet our coding style guidlines
(<http://webkit.org/coding/coding-style.html>) with regards to placement of &
characters and whitespace around "else" keywords.



More information about the webkit-reviews mailing list