[webkit-reviews] review granted: [Bug 13042] Linux/gdk improvements : [Attachment 13583] Linux\gdk improvements

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Sun Mar 11 15:27:01 PDT 2007

Brady Eidson <beidson at apple.com> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 13042: Linux/gdk improvements

Attachment 13583: Linux\gdk improvements

------- Additional Comments from Brady Eidson <beidson at apple.com>
+    notImplementedGdk(); // FIXME: possibly. Maybe implementation below is
good enough.
+    return item != 0;

Probably good enough for now, I don't think you need the notImplementedGdk().
But maybe you should document it better for future enhancement.  IE - file a
bug pending a future PolicyDelegate which would be the real "WebKit-way" of
doing this  ;)

Otherwise, looks good!

More information about the webkit-reviews mailing list