[webkit-reviews] review granted: [Bug 13021] XPath can be very slow : [Attachment 13578] partial fix 1

[bugzilla-request-daemon at macosforge.org]

Darin Adler <darin at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 13021: XPath can be very slow
http://bugs.webkit.org/show_bug.cgi?id=13021

Attachment 13578: partial fix 1
http://bugs.webkit.org/attachment.cgi?id=13578&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
r=me

One thing that's clearly a slow idiom is having functions with a return type
that's a Vector. Vector is not good for these purposes because returning one
involves allocating an entire new vector every time. It's better to pass a
Vector by value. Or we can wrap the vector so it works better as a return value
type. Or we can carefully code so we get the C++ return value optimization; but
that might not help enough.