[webkit-reviews] review requested: [Bug 9609] REGRESSION: Missing image icon needs to be moved back to WebKit : [Attachment 13570] Patch v1

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Fri Mar 9 16:49:43 PST 2007


David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 9609: REGRESSION: Missing image icon needs to be moved back to WebKit
http://bugs.webkit.org/show_bug.cgi?id=9609

Attachment 13570: Patch v1
http://bugs.webkit.org/attachment.cgi?id=13570&action=edit

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
Proposed patch implementing item 4 in Comment #1.

Compiles.  I wasn't sure how to test this since the method is a bit too complex
(IMO) for an ObjC test, although I didn't actually try that option yet.

I also thought about creating a new method that simply returns the missing
image (so that loadPlatformResource() isn't exported), but I'm not sure if
that's a concern or not.



More information about the webkit-reviews mailing list