[webkit-reviews] review requested: [Bug 12279] Two pass loading is needed when the network has high latency and low bandwidth : [Attachment 13537] updated patch according to review (rev 20051)

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Wed Mar 7 22:37:23 PST 2007


Grace Kloba <klobag at gmail.com> has asked  for review:
Bug 12279: Two pass loading is needed when the network has high latency and low
bandwidth
http://bugs.webkit.org/show_bug.cgi?id=12279

Attachment 13537: updated patch according to review (rev 20051)
http://bugs.webkit.org/attachment.cgi?id=13537&action=edit

------- Additional Comments from Grace Kloba <klobag at gmail.com>
I have updated the patch according to the comment from Darin.

The patch originally set the flag for MAC build to make testing easier. I have
changed it to depend on whether MOBILE is set as it is only needed when network
has low bandwidth.

I also modified all the names. Hope they are more related this time.

I was planning to reuse begin() when switch. But current code is not suitable.
Maybe we can re-factor them later to avoid duplicate code.

I did run through all 7416 LayoutTests with the flag on. There is an assertion
as I mentioned before. There are three other fail cases. But they are all fine
if I run the test with -1. I will continue look into them.



More information about the webkit-reviews mailing list