[webkit-reviews] review requested: [Bug 13004] Repeatedly calling XPathExpression.evaluate() causes crashes or memory leaks : [Attachment 13523] kill Expression::optimize()

[bugzilla-request-daemon at macosforge.org]

Alexey Proskuryakov <ap at webkit.org> has asked  for review:
Bug 13004: Repeatedly calling XPathExpression.evaluate() causes crashes or
memory leaks
http://bugs.webkit.org/show_bug.cgi?id=13004

Attachment 13523: kill Expression::optimize()
http://bugs.webkit.org/attachment.cgi?id=13523&action=edit

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
The expression optimization seems pretty much completely broken to me at the
moment. Everything from optimize() to isConstant() has major problems (though
it could be that I'm misunderstanding the design, of course).  I suggest just
removing it.

I have checked that fast/xpath tests take exactly the same time as they did.