[webkit-reviews] review granted: [Bug 12579] WebKit fails SVG
xml:base test : [Attachment 13481] Make baseURI virtual
bugzilla-request-daemon at macosforge.org
bugzilla-request-daemon at macosforge.org
Wed Mar 7 07:45:55 PST 2007
Darin Adler <darin at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 12579: WebKit fails SVG xml:base test
http://bugs.webkit.org/show_bug.cgi?id=12579
Attachment 13481: Make baseURI virtual
http://bugs.webkit.org/attachment.cgi?id=13481&action=edit
------- Additional Comments from Darin Adler <darin at apple.com>
+ void setDocumentURI(const String &);
Should not be a space here in String&.
+ KURL xmlbase(static_cast<const
Element*>(this)->getAttribute(XMLNames::baseAttr).deprecatedString());
Since you do using at the top of the file there's no need to specify XMLNames::
here. There's no need for the static_cast. This is in the Element class.
r=me
More information about the webkit-reviews
mailing list