[webkit-reviews] review denied: [Bug 12535] Stack-optimizing compilers can trick GC into freeing in-use objects : [Attachment 13507] Proposing fix

[bugzilla-request-daemon at macosforge.org]

Maciej Stachowiak <mjs at apple.com> has denied Maciej Stachowiak
<mjs at apple.com>'s request for review:
Bug 12535: Stack-optimizing compilers can trick GC into freeing in-use objects
http://bugs.webkit.org/show_bug.cgi?id=12535

Attachment 13507: Proposing fix
http://bugs.webkit.org/attachment.cgi?id=13507&action=edit

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
1) This will break the build on mac and linux since they call it alloca() not
_alloca() and prototype it in alloca.h, not malloc.h. Please fix that.

2) Is this definitely the only place affected? It looks like further up in the
comments, Ian Eng identified more potential trouble spots.

3) To fix just this one particular case, wouldn't it be simpler to just copy
val to a local UString variable on the stack? That avoids relying on something
unportable like alloca().

UString valCopy = val;
return new StringInstance(exec->lexicalInterpreter()->builtinStringPrototype(),
valCopy);

r- to at least address comment 1, since this will break the build otherwise.