[webkit-reviews] review requested: [Bug 12987] Fix and import 4XPath test_numeric_expr.html : [Attachment 13491] proposed fix

[bugzilla-request-daemon at macosforge.org]

Alexey Proskuryakov <ap at webkit.org> has asked  for review:
Bug 12987: Fix and import 4XPath test_numeric_expr.html
http://bugs.webkit.org/show_bug.cgi?id=12987

Attachment 13491: proposed fix
http://bugs.webkit.org/attachment.cgi?id=13491&action=edit

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
Not converting to DeprecatedString in Value::toNumber() helps because
DeprecatedString::ascii() has an apparent bug: all characters above 0xFF are
converted to \0, so toDouble("\u2022abc") returns 0 instead of failure.

I thought about fixing this globally, but the problem is deep inside
DeprecatedStringData:makeAscii(), and changing it now seems too dangerous to
me.