[webkit-reviews] review denied: [Bug 12963] Inconsistencies in JS array extras with Mozilla implementation : [Attachment 13470] Patch

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Sun Mar 4 21:58:38 PST 2007


Darin Adler <darin at apple.com> has denied Darin Adler <darin at apple.com>'s
request for review:
Bug 12963: Inconsistencies in JS array extras with Mozilla implementation
http://bugs.webkit.org/show_bug.cgi?id=12963

Attachment 13470: Patch
http://bugs.webkit.org/attachment.cgi?id=13470&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Thanks. This help is quite welcome!

It's hard to read this patch because it has so much context! I'm really used to
the plain old "-u".

The code change looks fine, but we need some test cases and a change log before
we can review+ this.



More information about the webkit-reviews mailing list