[webkit-reviews] review granted: [Bug 14320] <canvas> gradient stops at identical offsets are applied in the wrong order : [Attachment 15308] Use std::stable_sort and create <canvas> dynamically

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Pam Greene <pamg.bugs at gmail.com>'s
request for review:
Bug 14320: <canvas> gradient stops at identical offsets are applied in the
wrong order
http://bugs.webkit.org/show_bug.cgi?id=14320

Attachment 15308: Use std::stable_sort and create <canvas> dynamically
http://bugs.webkit.org/attachment.cgi?id=15308&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
r=me

One small thing should be improved.

-static int compareStops(const void* a, const void* b)
+inline bool compareStops(const CanvasGradient::ColorStop &a, const
CanvasGradient::ColorStop &b)

It's good for this to be inline, but it still needs to be internal linkage, so
it should say "static inline", not just "inline".