[webkit-reviews] review denied: [Bug 14437] CRASH: RTÃ video crashes Safari : [Attachment 15311] proposed fix
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Jun 30 08:09:43 PDT 2007
Darin Adler <darin at apple.com> has denied Maxime BRITTO <mbritto at pleyo.com>'s
request for review:
Bug 14437: CRASH: RTÃ video crashes Safari
http://bugs.webkit.org/show_bug.cgi?id=14437
Attachment 15311: proposed fix
http://bugs.webkit.org/attachment.cgi?id=15311&action=edit
------- Additional Comments from Darin Adler <darin at apple.com>
I think a better fix would be to put the frame pointer into a RefPtr rather
than simply returning nil in this case. I believe that will fix the bug in a
straightforward way. Just:
RefPtr<Frame> frame = m_frame;
And then use frame instead of m_frame throughout.
Other small issues: ChangeLog is missing a name and email address, needs to be
indented properly and misspells the word "function".
More information about the webkit-reviews
mailing list