[webkit-reviews] review requested: [Bug 14320] <canvas> gradient stops at identical offsets are applied in the wrong order : [Attachment 15308] Use std::stable_sort and create <canvas> dynamically

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 28 22:34:53 PDT 2007


Pam Greene <pamg.bugs at gmail.com> has asked  for review:
Bug 14320: <canvas> gradient stops at identical offsets are applied in the
wrong order
http://bugs.webkit.org/show_bug.cgi?id=14320

Attachment 15308: Use std::stable_sort and create <canvas> dynamically
http://bugs.webkit.org/attachment.cgi?id=15308&action=edit

------- Additional Comments from Pam Greene <pamg.bugs at gmail.com>
> this code could be switched to use std::stable_sort like RenderLayer.cpp does


> Should just fix this to use the right sorting algorithm instead.

> One sorting algorithm you could use is std::stable_sort.

Okay okay, I get the point. :-)  Here's that, along with a test change to
create the canvas elements dynamically.



More information about the webkit-reviews mailing list