[webkit-reviews] review denied: [Bug 13400] REGRESSION
(r20809-20814): No back entry created for navigations created
by assigning to document.location : [Attachment 15278] fix
above patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jun 27 21:00:45 PDT 2007
Adam Roben <aroben at apple.com> has denied Matt Perry <mpComplete at gmail.com>'s
request for review:
Bug 13400: REGRESSION (r20809-20814): No back entry created for navigations
created by assigning to document.location
http://bugs.webkit.org/show_bug.cgi?id=13400
Attachment 15278: fix above patch
http://bugs.webkit.org/attachment.cgi?id=15278&action=edit
------- Additional Comments from Adam Roben <aroben at apple.com>
+ bool userGesture = true;
+ frame->loader()->scheduleLocationChange(str,
activeFrame->loader()->outgoingReferrer(), !userGesture, userGesture);
There's no need for the userGesture variable anymore. Can you remove it?
More information about the webkit-reviews
mailing list