[webkit-reviews] review granted: [Bug 12045] Crash under gmalloc at WTF::RefPtr<WebCore::HTMLSliderThumbElement>::operator-> : [Attachment 15272] alternate patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 27 20:03:27 PDT 2007


Adam Roben <aroben at apple.com> has granted Sam Weinig <sam at webkit.org>'s request
for review:
Bug 12045: Crash under gmalloc at
WTF::RefPtr<WebCore::HTMLSliderThumbElement>::operator->
http://bugs.webkit.org/show_bug.cgi?id=12045

Attachment 15272: alternate patch
http://bugs.webkit.org/attachment.cgi?id=15272&action=edit

------- Additional Comments from Adam Roben <aroben at apple.com>
This one looks good to me, though I'd like to see an
ASSERT(o->parent()->isSlider()) in each implementation of paintSliderThumb().

r=me



More information about the webkit-reviews mailing list