[webkit-reviews] review denied: [Bug 13400] REGRESSION (r20809-20814): No back entry created for navigations created by assigning to document.location : [Attachment 15260] simple patch with slew of tests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 26 22:41:00 PDT 2007


Mark Rowe (bdash) <bdash at webkit.org> has denied 's request for review:
Bug 13400: REGRESSION (r20809-20814): No back entry created for navigations
created by assigning to document.location
http://bugs.webkit.org/show_bug.cgi?id=13400

Attachment 15260: simple patch with slew of tests
http://bugs.webkit.org/attachment.cgi?id=15260&action=edit

------- Additional Comments from Mark Rowe (bdash) <bdash at webkit.org>
You're missing a ChangeLog for your WebCore changes, and your layout test
results have hard-coded paths which are specific to your machine.  I believe
navigation tests need to be HTTP tests (http/tests/navigation) so that they
will have consistent paths across machines.



More information about the webkit-reviews mailing list