[webkit-reviews] review requested: [Bug 13400] REGRESSION (r20809-20814): No back entry created for navigations created by assigning to document.location : [Attachment 15260] simple patch with slew of tests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 26 16:26:07 PDT 2007


Matt Perry <mpComplete at gmail.com> has asked  for review:
Bug 13400: REGRESSION (r20809-20814): No back entry created for navigations
created by assigning to document.location
http://bugs.webkit.org/show_bug.cgi?id=13400

Attachment 15260: simple patch with slew of tests
http://bugs.webkit.org/attachment.cgi?id=15260&action=edit

------- Additional Comments from Matt Perry <mpComplete at gmail.com>
As Maciej suggested, I went with just forcing userGesture=true.

This does introduce a difference with Firefox: doing something like
onload="document.location = bla" does not create a back/forward item in
Firefox, but will for us.  I'm not sure whether that's a problem.  It seems
like overall this is an improvement (this brings us closer to Firefox in other
ways).



More information about the webkit-reviews mailing list