[webkit-reviews] review granted: [Bug 13038] ASSERTION FAILED:
item->target().isEmpty() ||
m_mainFrame->tree()->find(item->target()) == m_mainFrame :
[Attachment 15244] patch with cleaned up test case
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jun 26 14:00:17 PDT 2007
Geoffrey Garen <ggaren at apple.com> has granted Maxime BRITTO
<mbritto at pleyo.com>'s request for review:
Bug 13038: ASSERTION FAILED: item->target().isEmpty() ||
m_mainFrame->tree()->find(item->target()) == m_mainFrame
http://bugs.webkit.org/show_bug.cgi?id=13038
Attachment 15244: patch with cleaned up test case
http://bugs.webkit.org/attachment.cgi?id=15244&action=edit
------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
Wow! This patch has a long history. I believe all comments above have been
addressed.
Whoever lands this patch: please add newlines to the ends of the files. I would
ask the poster to do that, but I don't want to delay this patch any longer over
style issues.
More information about the webkit-reviews
mailing list