[webkit-reviews] review requested: [Bug 14373] CSS1: selectors (classes and IDs) cannot start with a dash or with a digit : [Attachment 15257] first attempt

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 26 12:58:38 PDT 2007


Rob Buis <rwlbuis at gmail.com> has asked	for review:
Bug 14373: CSS1: selectors (classes and IDs) cannot start with a dash or with a
digit
http://bugs.webkit.org/show_bug.cgi?id=14373

Attachment 15257: first attempt
http://bugs.webkit.org/attachment.cgi?id=15257&action=edit

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
This introduces no new shift/reduce conflicts. I have tried it on the
feature_branch where it improved two testcases (one was in the bug report) and
no regressions. However, someone may want to try it on ToT, maybe check for
speed regression and check whether some more elegant flex/bison approach can be
taken ( I am not an expert on those tools yet).
Cheers,

Rob.



More information about the webkit-reviews mailing list