[webkit-reviews] review granted: [Bug 14111] Autogenerate Event JS
binding : [Attachment 15250] just the event autogeneration
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jun 26 12:32:51 PDT 2007
Geoffrey Garen <ggaren at apple.com> has granted Sam Weinig <sam at webkit.org>'s
request for review:
Bug 14111: Autogenerate Event JS binding
http://bugs.webkit.org/show_bug.cgi?id=14111
Attachment 15250: just the event autogeneration
http://bugs.webkit.org/attachment.cgi?id=15250&action=edit
------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
Looks good to me, unless other reviewers object.
+ if (!event)
+ return KJS::jsNull();
+
+ KJS::ScriptInterpreter* interp =
static_cast<KJS::ScriptInterpreter*>(exec->dynamicInterpreter());
+
+ KJS::JSLock lock;
The lock here needs to go at the top of the function. jsNull() used to perform
a GC allocation. There's no guarantee it won't again at some time in the
future.
More information about the webkit-reviews
mailing list