[webkit-reviews] review denied: [Bug 14206] MSVC7 support and PLATFORM define fixes for Windows : [Attachment 15094] MSVC7 support and fixes for PLATFORM defines

[bugzilla-daemon at webkit.org]

Maciej Stachowiak <mjs at apple.com> has denied Kevin Ollivier
<kevino at theolliviers.com>'s request for review:
Bug 14206: MSVC7 support and PLATFORM define fixes for Windows
http://bugs.webkit.org/show_bug.cgi?id=14206

Attachment 15094: MSVC7 support and fixes for PLATFORM defines
http://bugs.webkit.org/attachment.cgi?id=15094&action=edit

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
Yes, please redo the conditionals like you said. Also, for the vsnprintf
changes, could you please make a wrapper of some kind (maybe just #define
vsnprintf _vsnprintf for the relevant compiler) instead of putting ifdefs at
every call site?

We prefer to avoid platform ifdefs in core code.

(Side not to Darin: on Windows the C library is distributed with the dev tools,
not with the OS, so I think the COMPILER checks are ok.)

Please revise.