[webkit-reviews] review denied: [Bug 14059] [CURL] Does not call didReceiveResponse() : [Attachment 14924] Parse header data and call didReceiveResponse() when appropriate

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 26 00:22:10 PDT 2007

Maciej Stachowiak <mjs at apple.com> has denied Alp Toker <alp at atoker.com>'s
request for review:
Bug 14059: [CURL] Does not call didReceiveResponse()

Attachment 14924: Parse header data and call didReceiveResponse() when

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
Good improvement, but while you're at it, how about parsing the response
headers too? Also, the curl docs imply that the callback you are changing gets
called once per received header line, seems like that would be bad. According
to libcurl docs:

"This function gets called by libcurl as soon as it has received header data.
The header callback will be called once for each header and only complete
header lines are passed on to the callback."

r- to revise in light of these comments.

More information about the webkit-reviews mailing list