[webkit-reviews] review denied: [Bug 14225] Make it possible to define platform-specific ResourceRequest without #ifdefs : [Attachment 15187] partial patch v2.1 (mac only)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 25 22:42:27 PDT 2007


Maciej Stachowiak <mjs at apple.com> has denied MorganL
<morganl.webkit at yahoo.com>'s request for review:
Bug 14225: Make it possible to define platform-specific ResourceRequest without
#ifdefs
http://bugs.webkit.org/show_bug.cgi?id=14225

Attachment 15187: partial patch v2.1 (mac only)
http://bugs.webkit.org/attachment.cgi?id=15187&action=edit

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
Looks good to me. We need at least a CFNetwork version as well to land this
(assuming it breaks the ResourceRequest build for other platforms). And I think
it would be good to convert the Qt and curl versions as well, to avoid breaking
the build for the Qt and Gtk ports. Otherwise looks great. Please submit a new
version that covers other platforms.



More information about the webkit-reviews mailing list