[webkit-reviews] review granted: [Bug 14288] REGRESSION: XMLHttpRequest doesn't use a correct content type for file:// URLs : [Attachment 15206] proposed fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 25 20:17:53 PDT 2007


Maciej Stachowiak <mjs at apple.com> has granted Alexey Proskuryakov
<ap at webkit.org>'s request for review:
Bug 14288: REGRESSION: XMLHttpRequest doesn't use a correct content type for
file:// URLs
http://bugs.webkit.org/show_bug.cgi?id=14288

Attachment 15206: proposed fix
http://bugs.webkit.org/attachment.cgi?id=15206&action=edit

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
This patch looks ok to me as is. However, maybe it would be better to parse
Content-Type ourselves for http, but trust the network layer for other
protocols. In particular, we might want to avoid the network layer's possible
content-based sniffing for XHMLHttpRequest.

The patch is fine as is however.



More information about the webkit-reviews mailing list