[webkit-reviews] review denied: [Bug 13686] REGRESSION: Certain iframes embedded in page listed in History menu : [Attachment 15051] cleaned up patch

[bugzilla-daemon at webkit.org]

Maciej Stachowiak <mjs at apple.com> has denied Maxime BRITTO
<mbritto at pleyo.com>'s request for review:
Bug 13686: REGRESSION: Certain iframes embedded in page listed in History menu
http://bugs.webkit.org/show_bug.cgi?id=13686

Attachment 15051: cleaned up patch
http://bugs.webkit.org/attachment.cgi?id=15051&action=edit

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
Fix looks good to me. Please add a layout test. I believe this could be tested
using dumpBackForwardList().

The comment is subtly wrong:

+	     // We only add the main frames to the history


We do, in fact, add loads of frames other than the main frame to the history,
if they are not initial loads, but that would not apply here.