[webkit-reviews] review denied: [Bug 13400] REGRESSION (r20809-20814): No back entry created for navigations created by assigning to document.location : [Attachment 15072] patch with regression test

[bugzilla-daemon at webkit.org]

Maciej Stachowiak <mjs at apple.com> has denied Matt Perry
<mpComplete at gmail.com>'s request for review:
Bug 13400: REGRESSION (r20809-20814): No back entry created for navigations
created by assigning to document.location
http://bugs.webkit.org/show_bug.cgi?id=13400

Attachment 15072: patch with regression test
http://bugs.webkit.org/attachment.cgi?id=15072&action=edit

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
Good catch, but I don't think this is quite the right fix. A location
assignment should add a new history item even if off a timer (at least if it's
not within a short time period of the original page load. See
modified-testcase.html.

In Firefox, it appears that assigning document.location in the normal way
*always* creates a new history item. See even-immediate-assignment.html. Given
this, I think the right thing is probably to always pass true as the
userGesture argument, but you may want to test other similar cases and add them
as LayoutTests if you think of other corner cases.

Otherwise this patch looks great!