[webkit-reviews] review denied: [Bug 13365] ASSERT in WebDocumentLoaderMac::decreaseLoadCount() un-discarding Gmail message : [Attachment 15116] proposed patch

[bugzilla-daemon at webkit.org]

Maciej Stachowiak <mjs at apple.com> has denied Maxime BRITTO
<mbritto at pleyo.com>'s request for review:
Bug 13365: ASSERT in WebDocumentLoaderMac::decreaseLoadCount() un-discarding
Gmail message
http://bugs.webkit.org/show_bug.cgi?id=13365

Attachment 15116: proposed patch
http://bugs.webkit.org/attachment.cgi?id=15116&action=edit

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
It should be impossible for the provisional document loader and the regular
document loader to ever be the same:
> +    if ((m_provisionalDocumentLoader && m_documentLoader) &&
(m_provisionalDocumentLoader != m_documentLoader)) {

Also, is the bug reproducible now or not? If the bug no longer happens, I'm not
sure we should make a change. If it does, then it needs a test case.

r- until these comments are addressed.