[webkit-reviews] review denied: [Bug 14389] [S60] Widget Menu API needs refinement : [Attachment 15232] 3.2 patch for menu api and preferences enhancement

[bugzilla-daemon at webkit.org]

Zalan Bujtas <zbujtas at gmail.com> has denied Sornalatha Rathnasamy
<sornalatha.rathnasamy at nokia.com>'s request for review:
Bug 14389: [S60] Widget Menu API needs refinement
http://bugs.webkit.org/show_bug.cgi?id=14389

Attachment 15232: 3.2 patch for menu api and preferences enhancement
http://bugs.webkit.org/attachment.cgi?id=15232&action=edit

------- Additional Comments from Zalan Bujtas <zbujtas at gmail.com>
widgetExtension.cpp line#860
>if ( newItem && oldItem && newItem->Text().Compare(newItem->Text()) != 0 )
shouldn't it be something like if ( newItem && oldItem &&
newItem->Text().CompareF(oldItem->Text()) == 0 ) ?

WidgetPreferences.cpp 
- remove tabs, please.
- line# 225, 251: missing CleanupStakc: PushL
- line# 436: use allocL() instead
- linr# 444: iValue = null; is missing and use allocL() instead.