[webkit-reviews] review denied: [Bug 14147] REGRESSION: No history item created when viewing "All Sizes" on Flickr : [Attachment 15184] patch with correct layout test

[bugzilla-daemon at webkit.org]

Mark Rowe (bdash) <bdash at webkit.org> has denied 's request for review:
Bug 14147: REGRESSION: No history item created when viewing "All Sizes" on
Flickr
http://bugs.webkit.org/show_bug.cgi?id=14147

Attachment 15184: patch with correct layout test 
http://bugs.webkit.org/attachment.cgi?id=15184&action=edit

------- Additional Comments from Mark Rowe (bdash) <bdash at webkit.org>
I went to land this patch but noticed that the test case it adds causes an
assertion failure to be hit.

$ run-webkit-tests
LayoutTests/http/tests/navigation/javascript-document-location-changed.html
LayoutTests/http/tests/navigation/javascript-document-location-changed.html
[...]
http/tests/navigation ..Assertion failed: ([bfList currentItem] !=
prevTestBFItem), function dumpBackForwardListForWebView, file
/Volumes/Data/Home/Documents/Work/OpenSource/WebKitTools/DumpRenderTree/DumpRen
derTree.m, line 768.

I hit this while regenerating the test results after removing the tab
characters, fixing spelling, and changing the test to dump as text.