[webkit-reviews] review denied: [Bug 14265] Cannot resize columns in webinspector : [Attachment 15190] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 22 22:31:17 PDT 2007


Timothy Hatcher <timothy at hatcher.name> has denied Matt Lilek
<pewtermoose at gmail.com>'s request for review:
Bug 14265: Cannot resize columns in webinspector
http://bugs.webkit.org/show_bug.cgi?id=14265

Attachment 15190: Patch
http://bugs.webkit.org/attachment.cgi?id=15190&action=edit

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
+function dividerDragEnd(element, dividerDrag, dividerDragEnd, event) 

You should put these functions in the WebInspector "namespace" like the other
functions.

Also the CSS for the sidebarResizeWidget should have cursor: col-resize;

Otherwise this is a r=me.

We still want to make resizing work by hovering over the divider line.



More information about the webkit-reviews mailing list