[webkit-reviews] review granted: [Bug 13884] patch for prepare-ChangeLog to populate ChangeLog files from a git commit : [Attachment 15186] fifth version

[bugzilla-daemon at webkit.org]

Adam Roben <aroben at apple.com> has granted Simon Hausmann <hausmann at kde.org>'s
request for review:
Bug 13884: patch for prepare-ChangeLog to populate ChangeLog files from a git
commit
http://bugs.webkit.org/show_bug.cgi?id=13884

Attachment 15186: fifth version
http://bugs.webkit.org/attachment.cgi?id=15186&action=edit

------- Additional Comments from Adam Roben <aroben at apple.com>
+	     $command = "$GIT diff -r --name-status -M \"$gitCommit^\"
\"$gitCommit\"";

   We should probably pass -C here as well.

     return $git{$status} if isGit();
+    return 0 if $gitCommit; # an existing commit cannot have conflicts

   Shouldn't these two lines be reversed?

+    # deliberately share the same description between svn status output and
git diff --name-status
+    return sprintf($svn{$status}, $original) if (isSVN() || $gitCommit) &&
exists $svn{$status};

   I guess we now know that the description for "R" is different for the
$gitCommit case.

   These are all pretty minor, so r=me either way, though I'd like to see them
addressed at some point.